Fix missing validation for binomial_steps in API#54
Merged
JohannesMeyerYC merged 1 commit intoMay 3, 2026
Merged
Conversation
Contributor
Author
|
I checked the latest CI runs on main, and the same checks are failing there as well, so this seems unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds validation for
binomial_stepsto ensure it is a positive integer.Changes
binomial_stepsinvalidate_portfolio_item()binomial_stepsin/price_optionResult
Invalid input now returns HTTP 400 instead of reaching the C++ layer.
Closes #53