Claude/spectrum autoplay fixes - #14
Merged
Merged
Conversation
…lant Rescan during playback caused errors and audible trouble because music-metadata parsing ran on the MAIN process event loop — the same loop that refills the WASAPI-exclusive ring every 10ms, services the RtAudio callbacks, and answers IPC. A real-library rescan starved all of it. - Library scanning now runs in a worker thread (electron/scan-worker.js) with the same incremental mtime logic, art caching, and progress events; main only writes the result and refreshes the media server. Cancel posts into the worker; a second Rescan click joins the running scan instead of racing it. - Scan strip: the final progress IPC event could arrive AFTER the scan invoke resolved, resurrecting the strip at 100% forever. Progress events are now gated by a scanActive flag. - Device writes (_outWrite) can no longer throw uncaught out of the 10ms pump interval — an invalidated device mid-write became a repeating main-process exception; now a rate-limited transient native:error toast. - Spectrum left edge: bars narrower than one FFT bin all flat-read the same bin and differed only by tilt — a rigid slanted ramp bouncing in unison. Sub-bin bars now interpolate at their center frequency, and the display floor is resolution-aware (max(30Hz, 1.5 bins)) so the bottom bars always have real data to differentiate them. - MediaSession artwork dropped: MediaImage rejects the auralis:// scheme and logged a console error on every track start. Verified live under Xvfb: rescan mid-playback → strip clears, zero renderer errors, playback uninterrupted. Bar-mapping suite extended with low-bar differentiation assertions (24/24 unique both engines); full regression suite passes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125mBkda6C4Yv2CiekXA6uW
Clicking the artist in an album's hero header now navigates to that artist's page (uses albumArtist — the same key the artist view filters on, so compilations resolve consistently). Hover styling matches the accent language. Verified live: album → artist click → artist page. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125mBkda6C4Yv2CiekXA6uW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.