Optimize AT state pruning with set-based deletion - #369
Open
ciber592 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #122
Summary
DELETEper block heightLatestATStatesATStateDataobjects and allocating intermediate address/state listsPreviously, pruning one height required two reads followed by one delete statement for every obsolete AT state. The new query lets HSQLDB identify and delete those obsolete rows directly with
NOT EXISTS.Validation
mvn -B -DskipJUnitTests=false -Dtest=PruneTests testmvn -B -DskipJUnitTests packagegit diff --checkPerformance evidence
A synthetic in-memory HSQLDB benchmark used 48,000
ATStatesrows across 1,200 heights and 40 AT addresses, with one latest state preserved per address. Median of three measured runs after warm-up:That is a 2.31x speedup in the synthetic benchmark and a 41.97x reduction in executed database statements. Persistent-node databases should particularly benefit from eliminating per-row delete round trips; the timing is synthetic and is included as directional evidence rather than a production guarantee.
Scope
The change is limited to
HSQLDBATRepository.pruneAtStates. No schema, API, or persisted-data-format changes are involved.