test(studio): remove brittle style source scan - #129
Merged
Conversation
Drop the Playwright case that reads CSS files and rejects raw source literals. The check does not exercise browser behavior and duplicated design-policy review as a regex gate, causing valid Studio changes to fail only in the one CI job that runs Playwright. Validated with the Studio build, 491 unit tests, and 51 Playwright browser tests on Node 24. Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The deleted case never opened a page. It used regexes over source text to enforce design policy, so it did not prove browser behavior and failed on a valid local white image background. This repository explicitly prefers behavior assertions over source-pattern checks.
Validation
Risk
Low. This removes a brittle policy gate but no runtime or UI behavior. Existing cross-layout and accessibility browser checks remain.