Skip to content

feat(composer): move selection chips below the textarea - #90

Closed
luoxuanzao wants to merge 1 commit into
mainfrom
feat/selection-row-below
Closed

luoxuanzao wants to merge 1 commit into
mainfrom
feat/selection-row-below

Conversation

@luoxuanzao

Copy link
Copy Markdown
Member

Summary

  • The top context row now carries only the image preview; editor/browser/canvas selection chips render in a new row between the textarea and the toolbar.
  • Highlighting text no longer inserts a strip above the typing area; the row appears under it instead and collapses when empty.
  • Overflow collapse ("+N more") and the has-content show/hide logic follow the chips; image changes refresh the top row directly.

Verification

  • npm run typecheck, npm run lint, npm run test (171 suites, 3585 tests), npm run build
  • Not yet exercised in a running Obsidian

The top context row now carries only the image preview. Editor, browser and
canvas selection chips render in a new row between the textarea and the
toolbar, so highlighting text no longer inserts a strip above the typing
area. The overflow collapse and the has-content show/hide logic follow the
chips to the new row; image changes refresh the top row directly.

Co-authored-by: QoderAI (Qwen 3.8 Max) <qoder_ai@qoder.com>
@luoxuanzao

Copy link
Copy Markdown
Member Author

Superseded: selections will become inline composer chips (@-style) instead of a separate row.

@luoxuanzao luoxuanzao closed this Sep 30, 2026
@luoxuanzao
luoxuanzao deleted the feat/selection-row-below branch September 30, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant