fix(release): keep package-lock.json in sync with the version bump - #88
Merged
Merged
Conversation
Release commits bumped package.json, manifest.json and versions.json but left package-lock.json carrying the previous version, so every npm install rewrote the lock's root version and showed the file as dirty in every worktree. sync-version now rewrites the lock's root entries too, the version script stages it, and release:check fails when the two disagree. Co-authored-by: QoderAI (Qwen 3.8 Max) <qoder_ai@qoder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonbut neverpackage-lock.json, so the lock kept the previous version and everynpm installshowed it as dirty in every worktree.scripts/sync-version.jsnow rewrites the lock's rootversionandpackages[""].version; theversionnpm script stages the lock;release:checkfails when lock and package versions disagree.Verification
npm run release:checkfails with the new message,node scripts/sync-version.jsfixes it, check passes againnpm run lint,npm run test(171 suites, 3600 tests)