Skip to content

Raise the Go toolchain floor to 1.27.4 - #32

Merged
PyYoshi merged 1 commit into
mainfrom
chore/go-1.27.4
Nov 16, 2026
Merged

PyYoshi merged 1 commit into
mainfrom
chore/go-1.27.4

Conversation

@PyYoshi

@PyYoshi PyYoshi commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Summary

Raise the Go toolchain floor in go.mod from 1.27.3 to 1.27.4. This fixes the lint job failure that currently blocks every PR, first seen on #31 (a Dependabot bump of zizmorcore/zizmor-action that is unrelated to the failure).

go1.27.4 (released 2026-11-10) carries security fixes to cgo, the go command, the compiler, the linker and net/http, plus bug fixes to the assembler, compiler, runtime, toolchain bootstrapping, and the crypto/fips140, crypto/hkdf, crypto/rsa, crypto/tls and net packages.

On go1.27.3, govulncheck v1.7.0 reports one of these, GO-2026-6859 (CVE-2026-97054), at symbol level and exits 3. The bug: an HTTP/1 server that uses MaxBytesReader can panic when the automatic Connection: close header set on limit overflow races with a header written by a handler that reads the body concurrently.

  • The library core does not import net/http (go list -deps . ./internal/proto shows none). The traces through internal/proto and internal/clamdtest are interface-dispatch over-approximations, because examples/httpupload is in the same ./... scan.
  • examples/httpupload does use MaxBytesReader, but it reads the body via FormFile before it writes any header, in the same goroutine, so the race does not apply there.

Changes:

  • go.mod: go 1.27.3 → go 1.27.4 (no toolchain line, no require).
  • CHANGELOG.md: a Changed entry under [Unreleased]. Downstream modules need go 1.27.4 or later.
  • README.md, README.ja.md and CONTRIBUTING.md say "Go 1.27+", which is still accurate (same precedent as the 1.27.3 bump in Raise the Go toolchain floor to 1.27.3 #27), so they are unchanged.

No public API, wire-protocol or security-default change, so no ADR is needed. Once this is merged, #31 needs a rebase so its lint job runs against the new floor.

Checklist

  • make verify passes locally (build + lint + tests). On go1.27.4: golangci-lint reports 0 issues, govulncheck -show verbose reports no vulnerabilities at any level, and the unit tests and the 397-row guard table pass
  • make integration passes (required when client.go / conn.go / commands.go / internal/proto/ / docker/ changed). Not required here because none of those changed; it was run anyway, locally on go1.27.4 against the docker compose clamd. CI covers 1.4 and 1.5
  • README.md and README.ja.md updated together, or the change touches neither
  • CHANGELOG.md updated under [Unreleased] for user-visible changes
  • No new dependencies, no assembled EICAR string, no weakened guards; design changes reference an ADR
  • Reviewed against the AGENTS.md Review checklist by someone other than the author, covering the merged commit (recorded in the PR); every finding fixed or answered

go1.27.4 (released 2026-11-10) carries security fixes to cgo, the go
command, the compiler, the linker and net/http. govulncheck v1.7.0 on
go1.27.3 reports one of them, GO-2026-6859 (CVE-2026-97054), at symbol
level, which fails the CI lint job on every PR (first seen on #31): an
HTTP/1 server using MaxBytesReader can panic when the limit-exceeded
"Connection: close" header races with a header written by a handler that
reads the body concurrently.

The library core does not import net/http (go list -deps shows none);
the traces through internal/proto and clamdtest are interface-dispatch
over-approximations caused by examples/httpupload being in the same
scan. That example does use MaxBytesReader, but reads the body via
FormFile before writing any header, in the same goroutine.

As with 1.27.3, the go directive in go.mod is this project's declared
toolchain floor and is expected to carry current stdlib security fixes:
actions/setup-go resolves it through go-version-file, and local
toolchains fetch it via GOTOOLCHAIN=auto. make verify and make
integration pass on go1.27.4, and govulncheck -show verbose reports no
vulnerabilities at any level.

README.md, README.ja.md and CONTRIBUTING.md state "Go 1.27+", which stays
accurate and needs no change.
@PyYoshi
PyYoshi merged commit 5e859c6 into main Nov 16, 2026
10 checks passed
@PyYoshi
PyYoshi deleted the chore/go-1.27.4 branch November 16, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant