Repository navigation
Raise the Go toolchain floor to 1.27.4 - #32
Merged
Merged
Conversation
go1.27.4 (released 2026-11-10) carries security fixes to cgo, the go command, the compiler, the linker and net/http. govulncheck v1.7.0 on go1.27.3 reports one of them, GO-2026-6859 (CVE-2026-97054), at symbol level, which fails the CI lint job on every PR (first seen on #31): an HTTP/1 server using MaxBytesReader can panic when the limit-exceeded "Connection: close" header races with a header written by a handler that reads the body concurrently. The library core does not import net/http (go list -deps shows none); the traces through internal/proto and clamdtest are interface-dispatch over-approximations caused by examples/httpupload being in the same scan. That example does use MaxBytesReader, but reads the body via FormFile before writing any header, in the same goroutine. As with 1.27.3, the go directive in go.mod is this project's declared toolchain floor and is expected to carry current stdlib security fixes: actions/setup-go resolves it through go-version-file, and local toolchains fetch it via GOTOOLCHAIN=auto. make verify and make integration pass on go1.27.4, and govulncheck -show verbose reports no vulnerabilities at any level. README.md, README.ja.md and CONTRIBUTING.md state "Go 1.27+", which stays accurate and needs no change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the Go toolchain floor in
go.modfrom 1.27.3 to 1.27.4. This fixes thelintjob failure that currently blocks every PR, first seen on #31 (a Dependabot bump ofzizmorcore/zizmor-actionthat is unrelated to the failure).go1.27.4 (released 2026-11-10) carries security fixes to cgo, the go command, the compiler, the linker and
net/http, plus bug fixes to the assembler, compiler, runtime, toolchain bootstrapping, and thecrypto/fips140,crypto/hkdf,crypto/rsa,crypto/tlsandnetpackages.On go1.27.3, govulncheck v1.7.0 reports one of these, GO-2026-6859 (CVE-2026-97054), at symbol level and exits 3. The bug: an HTTP/1 server that uses
MaxBytesReadercan panic when the automaticConnection: closeheader set on limit overflow races with a header written by a handler that reads the body concurrently.net/http(go list -deps . ./internal/protoshows none). The traces throughinternal/protoandinternal/clamdtestare interface-dispatch over-approximations, becauseexamples/httpuploadis in the same./...scan.examples/httpuploaddoes useMaxBytesReader, but it reads the body viaFormFilebefore it writes any header, in the same goroutine, so the race does not apply there.Changes:
go.mod:go 1.27.3→go 1.27.4(notoolchainline, norequire).CHANGELOG.md: aChangedentry under[Unreleased]. Downstream modules needgo 1.27.4or later.README.md,README.ja.mdandCONTRIBUTING.mdsay "Go 1.27+", which is still accurate (same precedent as the 1.27.3 bump in Raise the Go toolchain floor to 1.27.3 #27), so they are unchanged.No public API, wire-protocol or security-default change, so no ADR is needed. Once this is merged, #31 needs a rebase so its
lintjob runs against the new floor.Checklist
make verifypasses locally (build + lint + tests). On go1.27.4: golangci-lint reports 0 issues, govulncheck-show verbosereports no vulnerabilities at any level, and the unit tests and the 397-row guard table passmake integrationpasses (required whenclient.go/conn.go/commands.go/internal/proto//docker/changed). Not required here because none of those changed; it was run anyway, locally on go1.27.4 against the docker compose clamd. CI covers 1.4 and 1.5README.mdandREADME.ja.mdupdated together, or the change touches neitherCHANGELOG.mdupdated under[Unreleased]for user-visible changes