Skip to content

🧹 [code health] Refactor Remove-StartupEntry to reduce cyclomatic complexity - #57

Merged
Ahmed-Yaseen99 merged 2 commits into
mainfrom
refactor/reduce-remove-startupentry-complexity-17385465595261459286
Oct 15, 2026
Merged

Ahmed-Yaseen99 merged 2 commits into
mainfrom
refactor/reduce-remove-startupentry-complexity-17385465595261459286

Conversation

@Ahmed-Yaseen99

Copy link
Copy Markdown
Member

🎯 What:
Refactored Remove-StartupEntry in unslop-win11.ps1 and unslop-win10.ps1 by extracting property retrieval and filtering into Get-MatchedStartupEntries and unifying runKey loop control flow.

💡 Why:
Reduces high cyclomatic complexity and nesting depth in Remove-StartupEntry to improve readability and maintainability while preserving ADR-022 architectural isolation and 100% restoration symmetry.

✅ Verification:

  • Validated with Test-MasterGate.ps1 -Fast (AST parser clean, 0 PSScriptAnalyzer warnings/errors, 0 merge conflict markers).
  • Passed all Pester unit test assertions and static code analysis.

✨ Result:
Lower complexity, cleaner structure, zero behavioral changes.


PR created automatically by Jules for task 17385465595261459286 started by @Ahmed-Yaseen99

- Extract Get-MatchedStartupEntries helper function in unslop-win11.ps1 and unslop-win10.ps1.
- Consolidate runKey iteration and reduce nesting depth in Remove-StartupEntry.
- Preserve all registry backup, restore, dry-run and error trapping behaviors.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Ahmed-Yaseen99
Ahmed-Yaseen99 merged commit 55122d5 into main Oct 15, 2026
4 checks passed
@Ahmed-Yaseen99
Ahmed-Yaseen99 deleted the refactor/reduce-remove-startupentry-complexity-17385465595261459286 branch October 15, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant