Repository navigation
Follow the plugin template: acceptance tests, shared workflows, AGENTS.md - #3
Merged
Merged
Conversation
…_testing, shared workflows, AGENTS.md Remove the copies of the workflows (Test.yml, Testbase.yml, updater.yml) and call the reusable ones of pymodaq_plugins_template; add AGENTS.md and CLAUDE.md for AI coding assistants. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
acspy uses ctypes.windll at import time, which raises AttributeError on Linux and macOS and breaks plugin discovery. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
pymodaq>=5.3.2, pymodaq_utils>=5.3.1, pymodaq_gui>=5.3.0, pymodaq_data>=5.3.0, so that the acceptance tests and the rest of this change are met at install time. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
jerlfan
approved these changes
Oct 12, 2026
jerlfan
left a comment
jerlfan
left a comment
Collaborator
There was a problem hiding this comment.
Tested with check_plugin and on the setup, thanks!
Collaborator
|
Hello Sébastien, I tested the branch with check_plugin and on the setup, everything works, so I approved the PR. However, I cannot merge it: it seems I don’t have write access to the repository since the transfer. Could you give me the Maintain role on pymodaq_plugins_acs_motion? |
Author
|
you should be good. Wanna try? |
Collaborator
|
Hello Sébastien, The transfer is done: the repository is in the PyMoDAQ organization, the PyPI project now belongs to the pymodaq organization, and I merged PR #3 after testing it on the setup. Thanks for your help! Jérémie |
Author
|
I like when everything is green :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this plugin in line with
pymodaq_plugins_template(branch 5.3.x).tests/test_plugin_package_structure.py: replaced by the stub using the plugin acceptance checks of PyMoDAQ (pymodaq.utils.plugin_testing, PyMoDAQ >= 5.3.2, see the documentation). They check the naming of the modules and classes, the base class and mandatory methods,_axis_names/_controller_units/_epsilons, the settings tree, the entry points and static rules on the sources. Unfinished work (TODO comments) is listed, not failing. A module that cannot be imported because a vendor driver is missing on the CI runner is skipped, not failed. The module is skipped when PyMoDAQ is older than 5.3.2..github/workflows: the copies of the workflows are replaced by three small files calling the reusable workflows hosted inpymodaq_plugins_template:tests.yml(one fast configuration),compatibility.yml(Python 3.10 to 3.13, PyQt5/PyQt6/PySide6, Linux and Windows) andpython-publish.yml(same release trigger and the samePYPI_USERNAME/PYPI_PASSWORDsecrets as before). Nothing to update here anymore when GitHub actions or Python versions change.AGENTS.mdandCLAUDE.md: guidance for AI coding assistants working on the plugin (the PyMoDAQ plugin contract, units,is_master, tests).The
pymodaqrequirement ofpyproject.tomlis not changed. You can also runcheck_plugin(PyMoDAQ >= 5.3.1) in the folder of the plugin to get the full report, with the hints to fix each finding.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Generated by Claude Code