Feat: 3D extension to Structure Tensor slope estimation - #774
Merged
Conversation
mrava87
marked this pull request as draft
July 19, 2026 22:54
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 4 medium |
🟢 Metrics 16 complexity · 0 duplication
Metric Results Complexity 16 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
mrava87
marked this pull request as ready for review
July 21, 2026 22:00
…stimate and improve 3D sampling handling
cako
approved these changes
Jul 26, 2026
cako
left a comment
cako
left a comment
Collaborator
There was a problem hiding this comment.
Added a few changes, have a look! Otherwise looks good to me!
Collaborator
Author
Thanks, looks good! Definitely not a big fan of having different number and type of returns but without breaking backward compatibility I wasn't sure it was possible to avoid that... good addition with the overloads 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extended
slope_estimateto 3D inputs.It also includes some analytical tests both for the 2D and 3D scenario against plane waves with fixed slope/dip.