Repository navigation
Conversation
When a from-import name carries an inline comment that does not fit on one line, keep the name in the grouped import and hoist the comment to the opening parenthesis for vertical wrap modes. Previously the name was split onto its own statement and the next run regrouped differently, so isort --check rejected isort's own first-pass output. Fixes PyCQA#2694.
Author
|
Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a from-import name carries an inline comment that does not fit on one line (common with deeply-dotted modules under the
blackprofile), isort split that name onto its own statement. The next run then regrouped remaining names differently, soisort --checkrejected isort's own first-pass output.Keep the name in the grouped import and hoist the comment to the opening parenthesis for vertical wrap modes (and the existing hanging-indent
noqacase), matching the stable form isort already converges to.Fixes #2694.
Test plan