Skip to content

test: trigger Claude reviews across api/client/contracts scopes#144

Closed
loothero wants to merge 1 commit into
mainfrom
ci/test-claude-review-workflow
Closed

test: trigger Claude reviews across api/client/contracts scopes#144
loothero wants to merge 1 commit into
mainfrom
ci/test-claude-review-workflow

Conversation

@loothero

@loothero loothero commented May 3, 2026

Copy link
Copy Markdown
Member

Summary

Trivial cross-link addition (one identical line) to api/README.md, client/README.md, and contracts/README.md. The sole purpose is to exercise all three scoped Claude review jobs (and their Codex pairs) end-to-end after the v1 migration in #143:

  • client_review (changes under client/**)
  • indexer_api_review (changes under api/**)
  • contracts_review (changes under contracts/**)

Expected behavior on this PR:

  • All three claude-review-* jobs run on claude-code-action@v1.0.111 with --model claude-opus-4-7
  • Each job posts a ## Claude Review - … comment with a REVIEW_MARKER line
  • The Check for blocking findings step finds the comment and gates on [CRITICAL]/[HIGH]
  • pr-ci final gate passes

If the reviews surface real [HIGH] findings on this trivial doc change, that's a prompt-tuning issue, not a workflow issue — close and tune the prompt files.

Test plan

  • All four AI review jobs (Claude + Codex × 3 scopes — contracts/client/indexer-api) run, post comments, and pass blocking-findings check
  • claude-review-general is not triggered (no files outside the four scoped trees)
  • pr-ci passes
  • Close without merging once verified (the cross-link is harmless but unnecessary)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated README guidance across API, client, and contracts sections to add cross-references to the broader CI matrix.
    • Clarified where to find how CI jobs are scoped and how triggers map to jobs, improving discoverability of CI configuration details.

Copilot AI review requested due to automatic review settings May 3, 2026 12:00
@vercel

vercel Bot commented May 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
summit Ready Ready Preview, Comment May 4, 2026 0:47am

Request Review

@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8ca9df3f-736b-43e5-bd2b-17730ac3c1d4

📥 Commits

Reviewing files that changed from the base of the PR and between ef8ea74 and 08fe1b1.

📒 Files selected for processing (3)
  • api/README.md
  • client/README.md
  • contracts/README.md
✅ Files skipped from review due to trivial changes (3)
  • api/README.md
  • client/README.md
  • contracts/README.md

📝 Walkthrough

Walkthrough

Three README files (api, client, contracts) each add a short CI documentation pointer directing readers to ../AGENTS.md for the broader CI matrix and how triggers map to jobs.

Changes

Documentation Cross-References

Layer / File(s) Summary
Doc addition
api/README.md
Adds a CI note pointing to ../AGENTS.md describing the broader CI matrix and job-trigger scoping.
Doc addition
client/README.md
Adds a CI note pointing to ../AGENTS.md describing the broader CI matrix and job-trigger scoping.
Doc addition
contracts/README.md
Inserts a sentence directing readers to ../AGENTS.md for CI matrix and trigger scoping details.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I’m a rabbit with a doc-hopping grin,
Three READMEs nudged to look within,
“See AGENTS.md” they kindly say,
So CI paths won’t go astray,
Hopping off — good docs, begin! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the PR's primary purpose: testing Claude review triggers across three scopes (api/client/contracts).
Description check ✅ Passed The description clearly explains the purpose, expected behavior, and test plan, though it does not follow the structured template with marked checkboxes for Scope and Change Type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/test-claude-review-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README files for the API, client, and contracts directories to include a reference to the central CI matrix documentation in AGENTS.md. A review comment suggests moving the reference in contracts/README.md to the dedicated CI section to ensure consistency with the other README files and maintain logical grouping.

Comment thread contracts/README.md
Comment on lines +312 to +313

For the broader CI matrix (which scopes trigger which jobs), see `../AGENTS.md`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The placement of this CI reference at the end of the file is inconsistent with the structure of api/README.md and client/README.md, where it is correctly grouped under the ## CI section. In this file, it currently appears under the ## Important Development Rule section, which is misleading. It should be moved to the ### CI Pipeline section (around line 234) to maintain logical grouping and consistency across the repository's documentation.

@codecov

codecov Bot commented May 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@railway-app

railway-app Bot commented May 3, 2026

Copy link
Copy Markdown

🚅 Deployed to the summit-pr-144 environment in Summit

Service Status Web Updated (UTC)
summit-indexer ⏭️ Skipped (View Logs) May 4, 2026 at 12:47 am
summit-api ✅ Success (View Logs) Web May 3, 2026 at 12:02 pm
1 service not affected by this PR
  • summit-indexer

@railway-app railway-app Bot temporarily deployed to Summit / summit-pr-144 May 3, 2026 12:02 Destroyed
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - Indexer/API Review

No issues found.
Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - General Engineering Review

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the same documentation-only cross-reference to the api, client, and contracts READMEs so that touching each scoped tree will exercise the corresponding Claude/Codex review jobs after the CI migration in #143.

Changes:

  • Add a new line to api/README.md, client/README.md, and contracts/README.md referencing the broader CI matrix in the repo root.
  • Use those doc-only edits to trigger the scoped review workflows for api/**, client/**, and contracts/**.
  • Leave application code and workflow definitions unchanged.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
api/README.md Adds a CI-matrix reference in the API README to trigger the API/indexer review scope.
client/README.md Adds the same CI-matrix reference in the client README to trigger the client review scope.
contracts/README.md Adds the same CI-matrix reference in the contracts README to trigger the contracts review scope.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread api/README.md

`pnpm exec tsc --noEmit -> pnpm build`.

For the broader CI matrix (which scopes trigger which jobs), see `../AGENTS.md`.
Comment thread client/README.md

`lint -> build -> test:parity -> test:coverage -> Codecov`.

For the broader CI matrix (which scopes trigger which jobs), see `../AGENTS.md`.
Comment thread contracts/README.md
- `client/src/utils/translation.ts`
- parity scripts in `indexer/scripts/` and `client/scripts/`

For the broader CI matrix (which scopes trigger which jobs), see `../AGENTS.md`.
Comment thread contracts/README.md
- `client/src/utils/translation.ts`
- parity scripts in `indexer/scripts/` and `client/scripts/`

For the broader CI matrix (which scopes trigger which jobs), see `../AGENTS.md`.
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - Cairo/Starknet Contract Review

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - React/Frontend Review

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Claude Review - Cairo/Starknet Contract Review

No review output was produced.

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Claude Review - Indexer/API Review

No review output was produced.

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Claude Review - React/Frontend Review

No review output was produced.

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - Indexer/API Review

No issues found.
Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - React/Frontend Review

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - Cairo/Starknet Contract Review

No issues found.
Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Claude Review - Cairo/Starknet Contract Review

run=25290071732 attempt=1 sha=ef8ea749a877e1dfd092ece6022d8674fb65b9dc scope=contracts

No issues found.

The only contracts/** change in this PR is a single-line documentation addition to contracts/README.md cross-linking to ../AGENTS.md. No Cairo source, tests, or build configuration are touched, so there is no surface for security, idiom, testing, or gas findings.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

The diff in scope (indexer/** and api/**) is a single one-line cross-link addition to api/README.md. No code, schema, decoder, filter, finality, or migration changes are present. Nothing in this diff can affect data correctness, idempotency, stream filters, Serde decoding, reorg behavior, schema/migrations, or runtime config.

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Claude Review - React/Frontend Review

run=25290071732 attempt=1 sha=ef8ea749a877e1dfd092ece6022d8674fb65b9dc scope=client

No issues found.

The client diff is a single appended line in client/README.md cross-linking to the root AGENTS.md. There is no code, type, hook, wallet, query, or UX surface affected. The relative path ../AGENTS.md correctly resolves from client/README.md to the repo-root AGENTS.md, which exists.

Residual risks / testing gaps: none for this PR. As the PR body notes, this is a workflow-trigger smoke test; no manual smoke checks on /, /tournament/:id, /create-tournament, or /play are warranted.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - React/Frontend Review

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - Cairo/Starknet Contract Review

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

Codex Review - Indexer/API Review

No issues found.
Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

Trivial change to verify the Claude review workflow triggers correctly
across all three scopes (api, client, contracts) after the v1 migration
in #143.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@loothero loothero force-pushed the ci/test-claude-review-workflow branch from ef8ea74 to 08fe1b1 Compare May 4, 2026 00:47
@railway-app railway-app Bot temporarily deployed to Summit / summit-pr-144 May 4, 2026 00:47 Destroyed
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Claude Review - Cairo/Starknet Contract Review

run=25295680057 attempt=1 sha=08fe1b1240dfd20c8e16ed6c172311326efd201d scope=contracts

The only change within contracts/** is a single documentation line appended to contracts/README.md cross-linking to ../AGENTS.md. There are no Cairo source, test, or build changes to review.

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

The only change in scope is a single documentation line appended to api/README.md cross-linking to ../AGENTS.md. No code, schema, decoder, filter, migration, or runtime config changes.

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Claude Review - React/Frontend Review

run=25295680057 attempt=1 sha=08fe1b1240dfd20c8e16ed6c172311326efd201d scope=client

The client-scoped change in this PR is a single appended line to client/README.md adding a cross-link to ../AGENTS.md. There is no TypeScript, React, hook, query, wallet, or contract code in the diff to review.

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Codex Review - Cairo/Starknet Contract Review

No issues found.
Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Codex Review - Indexer/API Review

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Codex Review - React/Frontend Review

No issues found.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

@loothero loothero closed this May 4, 2026
@loothero loothero deleted the ci/test-claude-review-workflow branch May 4, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants