Encode beasts into token IDs#13
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request transitions the Beasts NFT collection to a deterministic token ID system, where the ERC721 token_id is a 53-bit packed representation of a beast's attributes. This architectural shift removes the need for the beasts storage map, as attributes are now decoded directly from the ID. The update includes refactoring the beasts_nft contract, ranking logic, and metadata generation, alongside comprehensive updates to the test suite to accommodate packed IDs. I have no feedback to provide as no review comments were submitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PackableBeastattributestoken_id -> PackableBeastdata and decode owned token IDs insteadNotes
total_supply()remains a count of minted NFTs, not the largest token ID.Tests
scarb fmt --check --workspacescarb buildsnforge test --max-n-steps 4294967295