Repository navigation
Keep Orrery fixtures independent of current imagery - #128
Merged
Merged
Conversation
Protonmatter
marked this pull request as ready for review
September 29, 2026 19:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The first daily data PR (#127) advances Earth imagery to 2026-09-28. The updater tests inherited that live date and the already-migrated raster path while their synthetic candidate stayed at 2026-09-27, causing normal staging and publisher fixture setup to fail the production rollback check.
Use a fixed historical synthetic weather baseline instead. Tests for existing daily imagery still stage once explicitly, and transition tests use the actual synthetic starting inventory. Add a regression with newer legacy and automated live records dated in 2030. Renderer tests also hard-coded the original September 12 observation date. They now assert the selected weather record's full observation label, including its unavailable state and absence under the historical composite. These two test files must be corrected before #127 can pass CI; no production validation is weakened.
Specification and traceability
SOL-TEST-001,SOL-DATA-002.docs/rfcs/0011-daily-orrery-refresh.md,docs/ORRERY_REFRESH.md.Correctness and risk
UI and UX
Not applicable: no UI or rendering changes. Keyboard, focus, touch, responsive behavior, reduced motion and availability states are unaffected. No new manual usability/accessibility qualification is claimed.
Validation evidence
Commands and results:
Independent review found no remaining actionable P0/P1/P2 issues and separately passed the new regression, both transition-admission tests, and the production rollback-rejection test. A targeted independent review also confirmed the browser label assertions preserve texture selection, gap disclosure, failure association and simulation-state checks.
Documentation