Skip to content

fix(tests): use sys.executable in doc-accuracy subprocess calls (unblocks the whole improve/goal pipeline) #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ProtocolWarden merged 1 commit into from
Jun 19, 2026
Merged

fix(tests): use sys.executable in doc-accuracy subprocess calls (unblocks the whole improve/goal pipeline) #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions tests/unit/test_documentation_accuracy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import re
import subprocess
import sys
from pathlib import Path

import pytest
Expand Down Expand Up @@ -47,7 +48,7 @@ def test_all_documented_markers_exist(self):
def test_marker_configuration_in_pytest(self):
"""All markers are configured in pytest configuration."""
result = subprocess.run(
["python", "-m", "pytest", "--markers"],
[sys.executable, "-m", "pytest", "--markers"],
capture_output=True,
text=True,
timeout=10,
Expand Down Expand Up @@ -220,7 +221,7 @@ class TestTestCommandExecutability:
def test_pytest_help_executes(self):
"""Basic pytest help command executes successfully."""
result = subprocess.run(
["python", "-m", "pytest", "--help"],
[sys.executable, "-m", "pytest", "--help"],
capture_output=True,
text=True,
timeout=10,
Expand All @@ -230,7 +231,7 @@ def test_pytest_help_executes(self):
def test_pytest_collect_only_succeeds(self):
"""pytest can collect tests without execution."""
result = subprocess.run(
["python", "-m", "pytest", "tests/unit", "--collect-only", "-q"],
[sys.executable, "-m", "pytest", "tests/unit", "--collect-only", "-q"],
capture_output=True,
text=True,
timeout=30,
Expand All @@ -241,7 +242,7 @@ def test_pytest_collect_only_succeeds(self):
def test_pytest_dry_run_integration_tests(self):
"""pytest can collect integration tests."""
result = subprocess.run(
["python", "-m", "pytest", "tests/integration", "--collect-only", "-q"],
[sys.executable, "-m", "pytest", "tests/integration", "--collect-only", "-q"],
capture_output=True,
text=True,
timeout=30,
Expand All @@ -251,7 +252,7 @@ def test_pytest_dry_run_integration_tests(self):
def test_pytest_markers_filter_works(self):
"""Pytest marker filters work correctly."""
result = subprocess.run(
["python", "-m", "pytest", "tests/", "-m", "perf", "--collect-only", "-q"],
[sys.executable, "-m", "pytest", "tests/", "-m", "perf", "--collect-only", "-q"],
capture_output=True,
text=True,
timeout=30,
Expand Down Expand Up @@ -378,7 +379,7 @@ class TestTestCountValidation:
def test_significant_number_of_unit_tests_exist(self):
"""A significant number of unit tests exist (documented as ~7,200)."""
result = subprocess.run(
["python", "-m", "pytest", "tests/unit", "--collect-only", "-q"],
[sys.executable, "-m", "pytest", "tests/unit", "--collect-only", "-q"],
capture_output=True,
text=True,
timeout=60,
Expand All @@ -393,7 +394,7 @@ def test_significant_number_of_unit_tests_exist(self):
def test_integration_tests_exist(self):
"""Integration tests exist in the project."""
result = subprocess.run(
["python", "-m", "pytest", "tests/integration", "--collect-only", "-q"],
[sys.executable, "-m", "pytest", "tests/integration", "--collect-only", "-q"],
capture_output=True,
text=True,
timeout=60,
Expand Down
Loading