🔥 ダメージの最低保証を削除#2282
Open
Lapis-LJA wants to merge 2 commits into
Open
Conversation
haiiro2gou
requested changes
Jun 27, 2026
Comment on lines
-50
to
-57
| # 最低値設定 | ||
| # $Modifier(e2) = max($Modifier(e2), (0.45 - $Difficulty * 0.10) * e2, 0) | ||
| function api:global_vars/get_difficulty | ||
| execute store result score $Difficulty Temporary run data get storage api: Return.Difficulty 10 | ||
| scoreboard players operation $Difficulty Temporary *= $-1 Const | ||
| scoreboard players add $Difficulty Temporary 45 | ||
| scoreboard players operation $Difficulty Temporary > $0 Const | ||
| scoreboard players operation $Modifier Temporary > $Difficulty Temporary |
Member
There was a problem hiding this comment.
MUST
- 最小値を 0 にする必要はありそう（バランスどうこうではなく、API の実装として）
haiiro2gou
approved these changes
Jul 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
このPRは、ダメージ補正計算（api:damage/core/modify_damage.m）に入っていた「難易度に基づく最低保証」ロジックを削除し、補正値が負にならない範囲でのみ下限を適用する形に整理する変更です。
Changes:
- 難易度（
Return.Difficulty）を参照して最低補正値を計算する処理を削除 - 補正値
$Modifierの下限を0にクランプする処理のみに簡略化
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+50
to
+51
| # 最低保証を0とする | ||
| scoreboard players operation $Modifier Temporary > $0 Const |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.