Skip to content

fix: #277 fix <svg> types #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thescientist13 merged 1 commit into from
Jun 28, 2026
Merged

fix: #277 fix <svg> types #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/jsx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@ type IntrinsicElementsFromSVG = {
[E in keyof SVGElementTagNameMap]: SVGElementAttributes<SVGElementTagNameMap[E]>;
};

type IntrinsicElementAttributes<E extends string> = (E extends keyof HTMLElementTagNameMap
? ElementAttributes<HTMLElementTagNameMap[E]> &
(E extends 'button' | 'input' ? PopoverAttributes : {}) &
(E extends 'button' ? { tabindex?: number | string } : {})
: {}) &
(E extends keyof SVGElementTagNameMap ? SVGElementAttributes<SVGElementTagNameMap[E]> : {});

type IntrinsicElementsMap = {
[E in keyof HTMLElementTagNameMap | keyof SVGElementTagNameMap]: IntrinsicElementAttributes<E>;
};

declare namespace JSX {
interface IntrinsicElements extends IntrinsicElementsFromDom, IntrinsicElementsFromSVG {}
interface IntrinsicElements extends IntrinsicElementsMap {}
}