Fixed bug in experiment scripts, updated Utilities/rsync scripts to rsync files in repo root#5
Merged
milindsrivastava1997 merged 1 commit intoMar 3, 2026
Conversation
…sync files in repo root
milindsrivastava1997
deleted the
2-tracking-issue-for-changes-to-port-over-from-the-private-repo
branch
GordonYuanyc
added a commit
that referenced
this pull request
Jun 2, 2026
…#5) Resolves the half-applied abstraction the reviewer flagged: the module no longer pretends to isolate the upstream sketch types. Accumulators now call the concrete `RuntimeCountMin`/`RuntimeKll` API directly for trivial operations, and `sketchlib_runtime` keeps only the logic worth sharing. Inlined (pure single-call delegations) into the accumulators: - cms_new -> RuntimeCountMin::with_dimensions(..) - cms_estimate -> self.inner.estimate(&DataInput::String(..)) - kll_new -> RuntimeKll::init_kll(k as i32) - kll_update -> self.inner.update(&value) Kept in sketchlib_runtime (real logic, not pass-throughs): - wire codec: cms_/kll_ to/from_msgpack, cms_matrix, cms_from_matrix - validated merge: cms_merge_refs, kll_merge_refs - guarded ops shared by >1 caller / carrying an invariant: cms_update (non-negative guard), kll_quantile (empty-sketch default), kll_sketch_bytes Module doc rewritten to state plainly that this is not an isolation layer, so the direct `self.inner.rows()/.cols()/.k()` accesses are intentional rather than a leak. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.