Removed old repo names in some places#4
Merged
Conversation
GordonYuanyc
added a commit
that referenced
this pull request
Jun 2, 2026
- #3: document the `value <= 0.0` guard in `cms_update` as an invariant (count-min cells are monotonic non-negative counters; a negative update would corrupt the queried key and every colliding key) and add the regression test `cms_update_drops_non_positive_values`. - #4: drop the hand-written `unsafe impl Send/Sync` for `DatasketchesKLLAccumulator` — `RuntimeKll` (`KLL<f64>`) is pure-Rust with no FFI handle, so the bounds auto-derive. New test `accumulator_is_send_sync` statically pins this against future fields. - #8: add the missing KLL merge error-path tests — k-mismatch and empty input — alongside the existing CMS dimension-mismatch coverage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.