feat(asap-planner): support SQL COUNT(DISTINCT) -> HLL streaming/inference config generation#385
Merged
milindsrivastava1997 merged 7 commits intoJun 1, 2026
Conversation
milindsrivastava1997
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support HLL-backed
CARDINALITYAggregationsSummary
Add end-to-end support for SQL
CARDINALITYusing HyperLogLog (HLL) sketches, including planner mapping, label routing, and configurable HLL precision.Changes
promql_utilities—query_logics/logics.rsMap:
to:
Set:
in
does_precompute_operator_support_subpopulations()so:grouping= SQLGROUP BYcolumnsaggregated= emptyDistinct values are stored in
value_column.Test:
test_cardinality_maps_to_hllasap-planner-rs—planner/sql.rsMap:
to:
For cardinality queries:
rollup = []grouping = GROUP BY columnsThe distinct column is sketched via
value_column, not treated as a rollup dimension.asap-planner-rs—planner/sketch.rsAdd
AggregationType::HLLsupport using:Default precision:
asap-planner-rs—config/input.rsAdd:
HllParamsSupport overrides:
asap-planner-rs—tests/sql_integration.rsAdd
spatial_count_distinct_hllvalidating:value_column: dstipgrouping: [srcip]rollupDeltaSetAggregatorExample
Produces:
with one HLL sketch per
srcipgroup.