Initial public release of ASAPQuery#1
Merged
Conversation
GordonYuanyc
added a commit
that referenced
this pull request
Jun 2, 2026
- kll_sketch_bytes / kll_to_msgpack now panic via .expect() instead of unwrap_or_default(), matching the cms_* path: silent empty bytes surface downstream as a misleading "buffer too short" (review #1). - cms_matrix uses .expect() instead of silently leaving 0.0 when storage.get() returns None, since None is only out-of-bounds and we iterate within reported dimensions (review #7). - _update on CountMinSketchAccumulator is now #[cfg(test)] with a comment documenting that production goes straight through cms_update; it exists only to exercise the same key-encoding path in a regression test (#2). - Document the Box<dyn Error> vs Box<dyn Error + Send + Sync> split in sketchlib_runtime so the inconsistency reads as deliberate (#6). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.