Merge pull request #85 from Project-SEA-Stack/refactor/wave-class-cleanup

Refactor wave classes: decouple parameters, frequency-domain excitation, code quality cleanup

Author: dav-og

data/reference_data/sphere/hc_ref_sphere_irreg_waves.txt

@@ -153,7 +153,7 @@ int main(int argc, char* argv[]) {
     // ---------------- End DT specific set up, now add hydro forces ----------------------------------
 
     // define wave parameters (not used in this demo TODO have hydroforces constructor without hydro inputs)
-    auto default_dont_add_waves = std::make_shared<NoWave>(3);
+    auto default_dont_add_waves = std::make_shared<NoWave>();
 
     // set up hydro forces
     std::vector<std::shared_ptr<ChBody>> bodies;

data/reference_data/sphere/hc_ref_sphere_irreg_waves_eta.txt

@@ -158,7 +158,7 @@ int main(int argc, char* argv[]) {
     system.AddLink(base_rev);
 
     // define wave parameters (not used in this demo TODO have hydroforces constructor without hydro inputs)
-    auto default_dont_add_waves = std::make_shared<NoWave>(3);
+    auto default_dont_add_waves = std::make_shared<NoWave>();
 
     // set up hydro forces
     std::vector<std::shared_ptr<ChBody>> bodies;

data/reference_data/sphere/hc_ref_sphere_irreg_waves_eta_consistency.txt

@@ -155,7 +155,7 @@ int main(int argc, char* argv[]) {
     anchor->SetConstrainedCoords(true, true, true, true, true, true);  // x, y, z, Rx, Ry, Rz
 
     // define wave parameters (not used in this demo TODO have hydroforces constructor without hydro inputs)
-    auto default_dont_add_waves = std::make_shared<NoWave>(3);
+    auto default_dont_add_waves = std::make_shared<NoWave>();
 
     // set up hydro forces
     std::vector<std::shared_ptr<ChBody>> bodies;

demos/f3of/demo_f3of_dt1.cpp

@@ -184,7 +184,7 @@ int main(int argc, char* argv[]) {
     revolute->Initialize(base_body, flap_body, ChFramed(ChVector3d(0.0, 0.0, -8.9), revoluteRot));
     system.AddLink(revolute);
 
-    auto default_dont_add_waves = std::make_shared<NoWave>(2);
+    auto default_dont_add_waves = std::make_shared<NoWave>();
 
     //// attach hydrodynamic forces to body
     std::vector<std::shared_ptr<ChBody>> bodies;

demos/f3of/demo_f3of_dt2.cpp

@@ -198,7 +198,7 @@ int main(int argc, char* argv[]) {
         bodies.push_back(flap_body);
         bodies.push_back(base_body);
 
-        auto my_hydro_inputs = std::make_shared<RegularWave>(static_cast<unsigned int>(bodies.size()));
+        auto my_hydro_inputs = std::make_shared<RegularWave>();
         my_hydro_inputs->regular_wave_amplitude_ = 0.01;
         my_hydro_inputs->regular_wave_omega_     = (2 * CH_PI) / (periods[reg_wave_num - 1]);
 

demos/f3of/demo_f3of_dt3.cpp

@@ -116,7 +116,7 @@ int main(int argc, char* argv[]) {
     prismatic_pto->SetDampingCoefficient(0.0);
     system.AddLink(prismatic_pto);
 
-    auto default_dont_add_waves = std::make_shared<NoWave>(2);
+    auto default_dont_add_waves = std::make_shared<NoWave>();
 
     // attach hydrodynamic forces to body
     std::vector<std::shared_ptr<ChBody>> bodies;

demos/oswec/demo_oswec_decay.cpp

@@ -133,7 +133,7 @@ int main(int argc, char* argv[]) {
     bodies.push_back(plate_body2);
 
     // define wave parameters
-    auto my_hydro_inputs                     = std::make_shared<RegularWave>(static_cast<unsigned int>(bodies.size()));
+    auto my_hydro_inputs                     = std::make_shared<RegularWave>();
     my_hydro_inputs->regular_wave_amplitude_ = 1.0;
     my_hydro_inputs->regular_wave_omega_     = 2.10;