Skip to content

fix(ci): satisfy clippy 1.97 so the Check job goes green - #7

Merged
MotherSphere merged 1 commit into
mainfrom
fix/clippy-1.97
Aug 1, 2026
Merged

fix(ci): satisfy clippy 1.97 so the Check job goes green#7
MotherSphere merged 1 commit into
mainfrom
fix/clippy-1.97

Conversation

@MotherSphere

Copy link
Copy Markdown
Member

The Check job has been red on all three runners since the toolchain
moved to 1.97: cargo clippy -- -D warnings reports 4 errors in the
bin target.

  • app.rs / stats.rs: three descending sort_by comparators become
    sort_by_key(|b| Reverse(..)) (clippy::unnecessary_sort_by). Both
    APIs are stable sorts and the key is the same value the comparator
    read, so the resulting order - ties included - is unchanged.
  • handlers/import.rs: drop the redundant & on an eprintln! argument
    (clippy::useless_borrows_in_formatting).
  • steam/mod.rs: move mod tests below full_import
    (clippy::items_after_test_module). Pure relocation, no line edited.

Also clears the lints that only --all-targets surfaces, so
cargo clippy --workspace --all-targets -- -D warnings is clean too:
crate-level //! header in the integration tests, struct-update syntax
instead of a post-default field assignment, .filter(is_game), and a
documented allow(dead_code) on the mock payload structs whose unread
fields exist to pin the API response shape.

The Check job has been red on all three runners since the toolchain
moved to 1.97: `cargo clippy -- -D warnings` reports 4 errors in the
bin target.

- app.rs / stats.rs: three descending `sort_by` comparators become
  `sort_by_key(|b| Reverse(..))` (clippy::unnecessary_sort_by). Both
  APIs are stable sorts and the key is the same value the comparator
  read, so the resulting order - ties included - is unchanged.
- handlers/import.rs: drop the redundant `&` on an eprintln! argument
  (clippy::useless_borrows_in_formatting).
- steam/mod.rs: move `mod tests` below `full_import`
  (clippy::items_after_test_module). Pure relocation, no line edited.

Also clears the lints that only `--all-targets` surfaces, so
`cargo clippy --workspace --all-targets -- -D warnings` is clean too:
crate-level `//!` header in the integration tests, struct-update syntax
instead of a post-default field assignment, `.filter(is_game)`, and a
documented `allow(dead_code)` on the mock payload structs whose unread
fields exist to pin the API response shape.
@MotherSphere
MotherSphere merged commit 7f5c913 into main Aug 1, 2026
3 checks passed
@MotherSphere
MotherSphere deleted the fix/clippy-1.97 branch August 1, 2026 12:00
@github-actions github-actions Bot mentioned this pull request Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant