docs: state the real licence - #2
Merged
Merged
Conversation
The LICENSE file has always held the verbatim FSF GPL-3.0 text, inherited byte-for-byte from jsnli/Samira. The README contradicted it outright, claiming "MIT, matching upstream" - false twice over, since upstream Samira is GPL-3.0 too and never was MIT. Anyone taking the README at its word would have redistributed GPL code under permissive terms. README.md: replace the MIT claim with GPL-3.0, and record why. Also expand the Samira credit - calling it the "original implementation" understated a relationship where the VDF parser, the Steamworks integration and the shape of the Rust backend are still largely upstream's code, which is what makes the copyleft carry forward in the first place. package.json, src-tauri/Cargo.toml: both shipped with no `license` field at all, so the only machine-readable answer was the README's wrong one. Declare GPL-3.0 in each. On the SPDX string: plain `GPL-3.0`, not `GPL-3.0-or-later`. Upstream ships the bare GPLv3 text with no "or any later version" notice applied to the program, and section 14 of that text grants the option of following a later version only "If the Program specifies that a certain numbered version of the GNU General Public License 'or any later version' applies to it". It does not. The fallback in the next paragraph - "If the Program does not specify a version number ... you may choose any version ever published" - is at best arguable here, since shipping the v3 text does identify a version. Rather than resolve that against the upstream author's silence, the version-neutral string claims nothing either way. Not touched: LICENSE itself (already the correct verbatim GPL-3.0 text, and identical to upstream's), colony.json (the Colony manifest schema has no licence field), the Valve Steamworks SDK note in bootstrap.rs, and the MIT entries in package-lock.json, which are third-party dependency metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LICENSE file has always held the verbatim FSF GPL-3.0 text, inherited
byte-for-byte from jsnli/Samira. The README contradicted it outright,
claiming "MIT, matching upstream" - false twice over, since upstream Samira
is GPL-3.0 too and never was MIT. Anyone taking the README at its word would
have redistributed GPL code under permissive terms.
README.md: replace the MIT claim with GPL-3.0, and record why. Also expand the
Samira credit - calling it the "original implementation" understated a
relationship where the VDF parser, the Steamworks integration and the shape of
the Rust backend are still largely upstream's code, which is what makes the
copyleft carry forward in the first place.
package.json, src-tauri/Cargo.toml: both shipped with no
licensefield atall, so the only machine-readable answer was the README's wrong one. Declare
GPL-3.0 in each.
On the SPDX string: plain
GPL-3.0, notGPL-3.0-or-later. Upstream shipsthe bare GPLv3 text with no "or any later version" notice applied to the
program, and section 14 of that text grants the option of following a later
version only "If the Program specifies that a certain numbered version of the
GNU General Public License 'or any later version' applies to it". It does not.
The fallback in the next paragraph - "If the Program does not specify a
version number ... you may choose any version ever published" - is at best
arguable here, since shipping the v3 text does identify a version. Rather than
resolve that against the upstream author's silence, the version-neutral string
claims nothing either way.
Not touched: LICENSE itself (already the correct verbatim GPL-3.0 text, and
identical to upstream's), colony.json (the Colony manifest schema has no
licence field), the Valve Steamworks SDK note in bootstrap.rs, and the MIT
entries in package-lock.json, which are third-party dependency metadata.