Skip to content

FORU-31151 Fix personal access clients in oauth#8839

Merged
nolanpro merged 1 commit into
developfrom
bugfix/FOUR-31130-b
Jun 3, 2026
Merged

FORU-31151 Fix personal access clients in oauth#8839
nolanpro merged 1 commit into
developfrom
bugfix/FOUR-31130-b

Conversation

@nolanpro
Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

If the oauth client id, often 1, is the same as the user attempting to authenticate, also often 1, then it fails.

I tried upgrading the schema to the new Passport clients schema but it caused too many problems so I'm keeping it the same for now.

See https://github.com/laravel/passport/blob/ea020190123953426a439f0267c6cfa478f6e6e7/src/Guards/TokenGuard.php#L146
and
https://github.com/laravel/passport/blob/ea020190123953426a439f0267c6cfa478f6e6e7/src/Client.php#L169

Solution

  • Set user id for the client to 1

How to Test

Describe how to test that this solution works.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Original PR #8823

@nolanpro nolanpro changed the title Use the original idea for fixing oauth clients FORU-31130 Fix personal access clients in oauth May 20, 2026
@processmaker-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nolanpro nolanpro changed the title FORU-31130 Fix personal access clients in oauth FORU-31151 Fix personal access clients in oauth May 20, 2026
@nolanpro nolanpro requested a review from gusys June 2, 2026 21:32
Copy link
Copy Markdown
Contributor

@gusys gusys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...

@nolanpro nolanpro merged commit 2575d5a into develop Jun 3, 2026
11 of 21 checks passed
@nolanpro nolanpro deleted the bugfix/FOUR-31130-b branch June 3, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants