Skip to content

fix: update test expectations and navigation selectors for location zoom levels#42

Merged
raven-wing merged 1 commit into
Problematy:mainfrom
raven-wing:tests_fixes
Feb 12, 2026
Merged

fix: update test expectations and navigation selectors for location zoom levels#42
raven-wing merged 1 commit into
Problematy:mainfrom
raven-wing:tests_fixes

Conversation

@raven-wing

@raven-wing raven-wing commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Tests

  • Improved navigation link detection with more robust selector logic
  • Expanded map zoom level test coverage to include zoom level 13

@coderabbitai

coderabbitai Bot commented Feb 12, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

These changes update test expectations and selectors to support a broader zoom level range (13-16 instead of 14-16) for location features and introduce a more robust home navigation element locator with fallback logic.

Changes

Cohort / File(s) Summary
Zoom Level & Tile Pattern Updates
tests/conftest.py, tests/basic/test_go_to_my_location.py
Expanded expected zoom level range from 14-16 to 13-16 by updating comment documentation and tile pattern regex to include zoom level 13.
Navigation Selector Refactoring
tests/basic/test_navigation.py
Replaced direct role-based home link lookup with a composite selector that first attempts an anchor with aria-label="Link to home page", then falls back to navbar-brand anchor, accessed via .first and clicked.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Whiskers twitching with delight,
Zoom levels wider—what a sight!
Selectors smarter, tests more keen,
The finest checks we've ever seen!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main
Title check ✅ Passed The title clearly and specifically summarizes the main changes: updating test expectations for zoom levels and improving navigation selectors, which aligns with the three files modified in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raven-wing raven-wing changed the title fix: tests fixes fix: update test expectations and navigation selectors for location zoom levels Feb 12, 2026
@github-actions

Copy link
Copy Markdown

🧪 E2E Test Results

📊 View full workflow run
🔗 Commit: f2b3277

📊 E2E Stress Test Performance

Status: PASSED (12867.14ms max < 25000ms limit)

Metric Value
Average Time 11001.21ms
Minimum Time 10010.09ms
Maximum Time 12867.14ms
Completed Runs 5/5
Avg Markers Loaded 71
📈 Individual Run Times
Run Time (ms) Markers
Run 1 10010.09ms 71
Run 2 10360.97ms 71
Run 3 10807.45ms 71
Run 4 10960.42ms 71
Run 5 12867.14ms 71

@raven-wing raven-wing merged commit b2b85b7 into Problematy:main Feb 12, 2026
2 checks passed
@raven-wing raven-wing deleted the tests_fixes branch February 12, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant