fix: improve chart toggle keyboard accessibility#734
Conversation
|
@Payal-20-06 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
The accessibility improvement is good, but there's one issue: focus:ring-indigo-500 is a raw Tailwind color — it breaks in light mode and won't follow the design system. Replace it with focus:ring-[var(--accent)] to stay consistent with the rest of the codebase.
|
CSS variable violation blocks merge:
Also remove the spurious blank line added between |
ad0a4dd
into
Priyanshu-byte-coder:main
|
🎉 Merged! Thanks for contributing to DevTrack. If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers. Keep an eye on open issues for your next contribution! |
Summary
Improved keyboard accessibility for the chart type toggle in ContributionGraph.
Changes Made
Added accessible button semantics for chart toggle controls
Added type="button" to prevent unintended form submissions
Added role="group" and aria-label="Chart type" to the toggle wrapper
Added aria-pressed state handling for active chart selection
Added visible keyboard focus styles using Tailwind focus ring utilities
Closes #46
Type of Change
Accessibility improvement
UI enhancement
Testing
Verified keyboard navigation using Tab key
Verified Enter and Space key interactions
Verified visible focus ring appears on focused toggle buttons
Confirmed chart switching functionality still works correctly