fix(client): actually unregister the requested plugin channel - #1536
Open
GoatTech-42 wants to merge 2 commits into
Open
GoatTech-42 wants to merge 2 commits into
GoatTech-42 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1534.
unregisterChannel()usedArray.find()and stored the matching channel name in a variable calledindex, then passed that string tosplice():JavaScript coerces a non-numeric channel string to
0, so unregistering any custom channel removed the first registered channel (usually the built-inminecraft:register) and left the requested channel active. The truthiness check would also have skipped a legitimate match at index0oncefindIndexwas used.The fix uses
findIndex()and tests for-1:Regression tests in
test/pluginChannelsTest.jscover both failure modes: the requested channel no longer receivescustom_payloadevents after being unregistered (previously the splice removed the wrong entry, so it stayed active), and a channel sitting at index 0 can be unregistered.