Conversation
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
Please retain the normalized enum API in this new 1.14.2 schema before landing. The full comparison with 1.14.1 found five mapper-to-primitive changes independent of protocol 485 and the trade-list layout. This is a source/schema review carried forward from earlier today at the unchanged head, not a fresh vanilla integration run.
Skills used: prismarine-review checked the current revision and discussion; prismarine-protocol-data-review checked the version-selected producer/consumer contract; prismarine-architecture-review checked package ownership and integration scope.
| packet_chat: | ||
| message: string | ||
| packet_client_command: | ||
| actionId: varint |
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
This copy restores raw numeric fields where adjacent supported versions expose symbolic mappers: client_command, entity_action, set_difficulty, difficulty, and game_state_change. For example, a caller using the established request_stats command name loses the mapping to the wire ordinal, while readers receive a different representation on 1.14.2 alone. Please preserve the current normalized mappings in the YAML and generated JSON, keeping only the actual version-specific wire changes. Validate named and numeric calls using NMP’s compiled codec; passing structural data tests alone does not check this consumer contract.
Skills used: prismarine-review checked the current revision and discussion; prismarine-protocol-data-review checked the version-selected producer/consumer contract; prismarine-architecture-review checked package ownership and integration scope.
|
Good catch, fixed. The 1.14.2 proto was copied from 1.14.1 with five mappers flattened to primitives: client_command, entity_action, set_difficulty, difficulty and game_state_change. I restored all five from the 1.14.1 schema (ordinals untouched, so wire compatible) and regenerated protocol.json with the repo build script. The proto is now identical to 1.14.1 apart from the version tag, which fits: the trade list layout is the same on both (no canRestock either side). Full suite passes (2050 passing, 0 failing), including the proto sync check. |
Split out of #1287.
1.14.2 had no entry at all. This adds its protocol, proto, commands and version files, with the rest borrowed through dataPaths like the other patch versions. One thing to know: the 1.14.2 trade list packet has no canRestock field, that only arrives in 490, so I left it out of the proto.
Full mocha suite passes (2050 passing, 0 failing).