fix(deps): resolve 7 Dependabot alerts (6 high, 1 moderate) - #3
Merged
Merged
Conversation
Bump mocha ^11.8.0 -> ^12.0.1 (pulls patched serialize-javascript 7.1.1, diff 9.0.0, js-yaml 5.4.1) and add range-scoped pnpm overrides pinning first patched versions of transitive deps under @vscode/vsce whose parents have not released fixes: js-yaml@<4.3.2 -> 4.3.2, fast-uri@<3.1.6 -> 3.1.6, qs@<6.16.0 -> 6.16.0. Closes: - GHSA-5c6j-r48x-rmvq (serialize-javascript RCE, high) - GHSA-qj8w-gfj5-8c6v (serialize-javascript DoS, moderate) - GHSA-jqff-g426-hqxp, GHSA-f65p-4m7j-42xc, GHSA-fph4-wmhf-6fwf, GHSA-5jgf-p345-68v8 (fast-uri host confusion / SSRF, high) - GHSA-2883-xcg3-v3hh (js-yaml CPU exhaustion, high) Verified: pnpm audit clean, lint and compile pass, test suite results identical to pristine-main baseline (pre-existing failures unrelated). 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 7 currently open Dependabot alerts on
main(6 high, 1 moderate). All affected packages are transitive devDependencies (test/packaging tooling), so there is no runtime exposure, but the alerts are resolved at the lockfile level.Changes (3 files)
package.json— bump devDependencymocha^11.8.0→^12.0.1. Mocha 12 natively depends on patchedserialize-javascript ^7.1.1,diff ^9.0.0, andjs-yaml ^5.0.0, resolving both serialize-javascript alerts without overrides. The programmaticMochaAPI used bysrc/test/suite/index.tsis stable across the major.pnpm-workspace.yaml— add range-scopedoverridespinning the first patched versions for transitive deps under@vscode/vscewhose parents have not yet released compatible fixes:js-yaml@<4.3.2→4.3.2fast-uri@<3.1.6→3.1.6qs@<6.16.0→6.16.0(qs DoS advisory; no separate Dependabot alert was open for it)Range-scoped so only vulnerable resolutions are forced; exact versions (not
>=) to keep the blast radius minimal. Remove the overrides once upstream parents bump their ranges.pnpm-lock.yaml— regenerated accordingly.Verification
pnpm audit→ "No known vulnerabilities found" (previously 7 findings, matching the Dependabot alerts 1:1 via the same GitHub Advisory Database)pnpm run lint→ passpnpm run compile(tsc) → passPASS: 518, FAIL: 35— byte-for-byte identical to a baseline run on a pristine checkout ofmain(mocha 11.8.0); the 35 failures are pre-existing onmain(unrelatedread only property 'createDirectory'vscode-mock hook errors) and unaffected by this changeNotes
pnpm-workspace.yamlare intended as a temporary measure; they should be dropped when@vscode/vsce(or its dependencies) release versions with compatible patched ranges.