NCI3D bugfixes + added test for full kernel (mesh data excluded) - #2012
Open
int-ptr-ptr wants to merge 2 commits into
Open
NCI3D bugfixes + added test for full kernel (mesh data excluded)#2012int-ptr-ptr wants to merge 2 commits into
int-ptr-ptr wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please describe the changes/features in this pull request.
impl::compute_couplingkernel test (not added tocmake, yet since meshes will be in separate PR.(ispec, ipoint, jpoint)has exactly one coupled face + local coordinates, with its interpolated position being "close enough" to the node.Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.