-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/basic score #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
38e3929
Reorganize span methods into span_utils module
laurejt 6bd6163
Remove ignore label flag from span utils
laurejt 28e0ee7
Add custom composite match score
laurejt 90e3d5f
Add metrics methods
laurejt 81d0040
Add AlignSpans constructor
laurejt 970a21f
Make DocSpans hashable
laurejt 2e25b05
Add script for computing aggregated eval metrics
laurejt e19068e
Update changelog
laurejt 9c79dc6
Remove unused custom pytest fixtures
laurejt b1f6697
Update src/spanerr/compute_metrics.py
laurejt bcb1631
Update CHANGELOG.md
laurejt 0039d7e
sys_json --> sys_dict
laurejt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere (probably not here) it would be helpful to have a note explaining why the lambda approach - once I finished reading through the function I saw how many variations there are, which I presume is the motivation. It would be helpful to have that explained at a higher level first - maybe a file- level docstring? (Or maybe a design doc if you add some version of that to the code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I'll open an issue for tracking this.