Skip to content

fix: bracket-notation for needs['smoke-test'] #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarioSieg merged 1 commit into from
Aug 27, 2026
Merged

fix: bracket-notation for needs['smoke-test'] #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/build_kernels.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,14 +248,19 @@ jobs:
# should build and smoke-test, not publish. Without this, every push to a PR branch
# would create and publish a real release the moment build+smoke-test go green.
#
# needs.smoke-test.result tolerates 'skipped' as well as 'success': smoke-test is
# currently disabled (see its `if: false`) until the GPU runner is registered, and
# a skipped dependency fails the default needs.*-implied success() check — without
# this, disabling smoke-test would also silently block every release.
# needs['smoke-test'].result tolerates 'skipped' as well as 'success': smoke-test
# is currently disabled (see its `if: false`) until the GPU runner is registered,
# and a skipped dependency fails the default needs.*-implied success() check —
# without this, disabling smoke-test would also silently block every release.
#
# Bracket notation is required, not `needs.smoke-test.result`: GitHub Actions
# expressions parse a bare `-` in dot-access as subtraction, not part of the name,
# so the dotted form silently evaluates as garbage instead of erroring — which is
# exactly how this job ended up skipping releases with no annotation at all.
if: |
github.event_name != 'pull_request' &&
needs.build.result == 'success' &&
(needs.smoke-test.result == 'success' || needs.smoke-test.result == 'skipped')
(needs['smoke-test'].result == 'success' || needs['smoke-test'].result == 'skipped')
runs-on: ubuntu-latest
permissions:
contents: write
Expand Down
Loading