Fix: SQL queries using NOW() rely on MySQL timezone instead of shop timezone#177
Closed
mattgoud wants to merge 1 commit into
Closed
Fix: SQL queries using NOW() rely on MySQL timezone instead of shop timezone#177mattgoud wants to merge 1 commit into
mattgoud wants to merge 1 commit into
Conversation
Replace NOW() in raw SQL queries with PHP's date() so that the shop's configured timezone is always used instead of the MySQL server timezone (UTC). Fixes PrestaShop/PrestaShop#30828 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hello @mattgoud! This is your first pull request on ps_googleanalytics repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Contributor
Author
|
Closed. Alternative solution proposed by the PR PrestaShop/PrestaShop#41628 |
github-project-automation
Bot
moved this from Ready for review
to Closed
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
- `GanalyticsRepository::findAllByShopIdAndDateAdd()`: `DATE_ADD(date_add, ...) < NOW()` replaced with a PHP-computed datetime string
- `GanalyticsRepository::addOrder()` and `markOrderAsSent()`: `NOW()` SQL value replaced with `date('Y-m-d H:i:s')`
- `HookDisplayBackOfficeHeader`: `BETWEEN NOW() - INTERVAL x DAY AND NOW() - INTERVAL 30 MINUTE` replaced with PHP-computed interval boundaries