feat: incorporate PetroglyphTools + knowledge-base (vendored/data trees)#189
Merged
Merged
Conversation
Adds two read-only support trees from the SWFOC RE workspace: - PetroglyphTools/ third-party SWFOC modding tools (C#), reproduced verbatim for provenance (not part of SwfocTrainer.sln; not first-party-maintained). - knowledge-base/ reverse-engineering notes + machine-generated decompile/data JSON (45.5k files) + a SQLite call-graph index. Storage: - Git LFS tracks the binary blobs only (callgraph_index.sqlite + PetroglyphTools .dat / .meg game-data + test fixtures) via .gitattributes; ~43 MB LFS total. All JSON/Markdown/JSONL stays in normal git (text). - linguist-vendored (PetroglyphTools) / linguist-generated (knowledge-base) keep them out of GitHub language stats and collapse them in diffs. Lean quality gate - scoped OUT consistently with the existing vendored RE editor trees (bridge/imgui/minhook/ghidra_scripts); first-party scope is unchanged: - ruff.toml extend-exclude, pyrightconfig.json exclude, .coveragerc omit (no first-party Python lives under either tree) - .gitleaks.toml allowlist paths (baseline scan 2026-06-28: 0 leaks in both) - .github/codeql/codeql-config.yml paths-ignore (PetroglyphTools is C#) - .pre-commit-config.yaml exclude - osv-scanner: no change needed - scan source extracts 0 package sources from either tree (bare .csproj without a NuGet lockfile; knowledge-base has no manifests); verified 2026-06-28. Documented in osv-scanner.toml.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
🚧 Skipped: PR exceeds review size limit. Please split into smaller PRs and re-run. |
…upstream PetroglyphTools multi-targets .NET 10, which breaks GitHub's native "Automatic dependency submission" (the Actions runner SDK cannot restore net10 projects) - a recurring red on this repo. Remove the vendored PetroglyphTools tree (1090 files) and the PetroglyphTools-specific entries the incorporation commit added to the lean-gate config (.gitattributes LFS + linguist-vendored, ruff.toml extend-exclude, pyrightconfig.json exclude, .coveragerc omit, .pre-commit-config.yaml exclude, .gitleaks.toml allowlist, .github/codeql/codeql-config.yml paths-ignore, osv-scanner.toml). Keep the knowledge-base tree (RE notes + decompile/data JSON + its LFS object callgraph_index.sqlite) and all of its config entries intact. Document where to obtain PetroglyphTools (AlamoEngine-Tools upstream) in docs/EXTERNAL-TOOLS.md, linked from README. Lean gate verified locally (ruff 0.15.17, oxlint 1.69.0, biome 2.5.0, gitleaks 8.30.1, osv-scanner 2.3.8 all green). No .csproj added, so the Automatic dependency submission check recovers.
|
🚧 Skipped: PR exceeds review size limit. Please split into smaller PRs and re-run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Incorporates two read-only support trees from the SWFOC reverse-engineering workspace:
PetroglyphTools/— third-party SWFOC modding tools (C#), reproduced verbatim for provenance (a separate solution, not part ofSwfocTrainer.sln; not first-party-maintained).knowledge-base/— reverse-engineering notes + machine-generated decompile/data JSON (45.5k files) + a SQLite call-graph index.(
ghidra_projectfrom the source workspace is intentionally not included.)Storage (Git LFS)
callgraph_index.sqlite+ PetroglyphTools*.dat/*.meggame-data and test fixtures (via.gitattributes). ~43 MB LFS total (well within the free tier).linguist-vendored(PetroglyphTools) /linguist-generated(knowledge-base) keep them out of GitHub language stats and collapse them in diffs.Lean quality gate — scoped out as vendored/data (first-party scope unchanged)
Consistent with how the repo already handles
bridge/imgui/minhook/ghidra_scripts:ruff.tomlextend-exclude — no first-party Python in either treepyrightconfig.jsonexclude.coveragercomit — already outsidesource(scripts/tools).gitleaks.tomlallowlist — baseline scan 2026-06-28: 0 leakscodeql-config.ymlpaths-ignore — PetroglyphTools is C#.pre-commit-config.yamlexcludescan sourceextracts 0 package sources from both trees (bare.csproj, no NuGet lockfile; knowledge-base has no manifests). Verified and documented inosv-scanner.toml.Local verification (pinned tools, on the committed tree)
check+format --check→ passci(bundled config) → pass (checked only the 2 first-party JS files; ignored all 45k JSON)--deny-warnings→ passdetect→ no leaks foundscan source --recursive .→ no issues found (0 packages from new dirs)