feat(outcomechip): add contextual help popover for first-time users (Closes #751) - #875
Open
waterWang wants to merge 1 commit into
Open
Conversation
Adds optional helpContent prop to OutcomeChip that renders a MechanicHelp popover with contextual information about the outcome metric/field. - New helpContent prop accepts MechanicHelpContent (type from MechanicHelp) - Help icon embedded in the chip with stopPropagation to prevent onSelect - Responsive: uses MechanicHelp's built-in desktop popover + mobile drawer - WCAG 2.1 AA: help button has aria-label, keyboard accessible - New tests: help button renders/omits, stopPropagation on click Closes Predictify-org#751
|
@waterWang is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
helpContentprop to OutcomeChip that renders aMechanicHelppopover with contextual information about the outcome metric/field, helping first-time users understand what they're selecting.Changes:
OutcomeChip.tsx: AddedhelpContent: MechanicHelpContentprop + help icon wired to stopPropagation so clicking help does not trigger chiponSelectOutcomeChip.test.tsx: 3 new tests — help button renders withhelpContent, omitted without, and stopPropagation on clickAccessibility: Help button has
aria-labeland is keyboard focusable. Tooltip + popover/drawer pair follows WCAG 2.1 AA.Closes #751