feat(wallet-modal): add tooltip primitive to copy-address button (Closes #783) - #872
Open
waterWang wants to merge 1 commit into
Open
feat(wallet-modal): add tooltip primitive to copy-address button (Closes #783)#872waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Predictify-org#783) Wrap the copy-address icon-only button in WalletModal with the shared Tooltip primitive (TooltipProvider / Tooltip / TooltipTrigger / TooltipContent). The tooltip shows 'Copy wallet address' by default and switches to 'Address copied' after the address is copied, mirroring the existing aria-label. Improves discoverability of the icon-only control for mouse and touch users (long-press) while keeping WCAG 2.1 AA accessibility.
|
@waterWang is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the shared Tooltip primitive to the icon-only copy-address button in
WalletModal(Closes #783).The copy button already had an
aria-labelfor screen readers, but sighted mouse/touch users had no visual affordance explaining what the small icon does. This change wraps it in the repo'sTooltipprimitive:aria-labelbehavior.Changes
src/pages/WalletModal.tsxTooltipProvider,Tooltip,TooltipTrigger,TooltipContentfrom@/components/ui/tooltip.<button>in the tooltip, with dynamic content keyed on thecopiedstate.src/pages/__tests__/WalletModal.test.tsx@/constants/wallet-kits.constantto avoid the ESMstellar-wallets-kitimport failing under Jest.WalletModal — copy-address tooltip (#783)describe block with two new tests:Accessibility (WCAG 2.1 AA)
role="tooltip"+aria-describedby).Test
Closes #783