feat(bet-form): add sticky action bar on BetForm while scrolling (Closes #808) - #864
Open
waterWang wants to merge 1 commit into
Open
feat(bet-form): add sticky action bar on BetForm while scrolling (Closes #808)#864waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
|
@waterWang is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
Adds a sticky bottom action bar to BetForm that stays pinned to the bottom of the form while the preset chips and amount input scroll within a constrained container. - Wraps QuickBetPresets and the amount input in a max-h overflow-y-auto scrollable container so the form stays compact on small viewports. - The submit button (Place Bet) is now wrapped in a sticky bottom-0 action bar that remains reachable while the content scrolls. - Grows a top border + shadow once the body has been scrolled (tracked via onScroll), so it reads as a floating bar over content rather than empty space when everything fits without scrolling. - Respects reducedMotion (suppresses the shadow transition). - Adds focused unit tests for the sticky action bar behavior. Closes Predictify-org#808
waterWang
force-pushed
the
feat/betform-sticky-action-bar
branch
from
August 8, 2026 19:32
17cffe8 to
06579fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #808
Summary
Adds a sticky bottom action bar to
BetFormthat stays reachable while the preset chips and amount input scroll within a constrained container.Changes
QuickBetPresetsand the amount input in amax-h-[min(60vh,26rem)] overflow-y-autocontainer so the form stays compact on small viewports and the content scrolls independently.Place Bet) is now wrapped in asticky bottom-0action bar that remains pinned to the bottom of the form as content scrolls beneath it.onScrollhandler), so it reads as a distinct bar floating over content rather than empty visual space when everything already fits without scrolling.BetForm.sticky-action-bar.test.tsx) covering render, sticky positioning, scroll-state shadow, non-scroll state, and submit behavior.Testing
jest BetForm.sticky-action-bar(all new tests pass)BetFormbehavior unchanged (submit, keyboard shortcut, skeleton)Accessibility