feat: add high-contrast mode overrides for NotificationsPanel (Closes #812) - #860
Open
waterWang wants to merge 1 commit into
Open
Conversation
|
@waterWang is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds high-contrast mode (
prefers-contrast: more) overrides for the NotificationsPanel component (Closes #812).When a user's OS is set to "more contrast", translucent borders, subtle background tints, and low-contrast text become hard to read. This PR ensures every interactive and informational element in the notifications panel has a distinct visual boundary.
Changes
src/styles/contrast.css(new)Defines
@media (prefers-contrast: more)overrides scoped to the.notifications-panelcontainer:border/60borders on the list container and rows.aria-current) get a more pronounced accent background so they're distinguishable without relying on hue.src/pages/NotificationsPanel.tsxnotifications-panelwrapper class to the page container so the high-contrast overrides are scoped and don't affect other components.../styles/contrast.css.src/pages/__tests__/NotificationsPanel.test.tsxAdded a
high-contrast modetest group:.notifications-panelwrapper class is applied.../styles/contrast.css.border-bordertoken the contrast overrides depend on.WCAG 2.1 AA compliance
aria-currentattribute (not hue alone).Verification
tsc --noEmitreports no errors in the touched files.React.act is not a function) unrelated to this change;next buildfails on a pre-existing missing font path inapp/api/og/route.tsx, also unrelated.