fix(uptime-kuma): mark the PVC as the recurring job source - #79
Merged
Merged
Conversation
Longhorn only syncs recurring-job labels from a PVC to its volume when the PVC also carries recurring-job.longhorn.io/source=enabled. The volume was provisioned without the job label and stayed on the default group. Add the source label and correct the README. Signed-off-by: Pragalva Sapkota <sapkotapragalva@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
After #77 the Longhorn volume never picked up
recurring-job.longhorn.io/uptime-kuma-daily. Recreating the PVC did not help either. Longhorn's docs say a PVC's recurring-job labels are synced to the volume only when the PVC also carriesrecurring-job.longhorn.io/source: enabled. Without it the job label is inert and the volume stays in thedefaultgroup.Fix
recurring-job.longhorn.io/source: enabledto the PVC labels.Argo applies the label in place. No PVC recreation, no data movement.
Validation
kubeconform -strictandscripts/check-docs.pypass.After merge