fix(ci): always run test-api and helm-lint so required status checks never skip - #88
Open
Pragadeesh122 wants to merge 2 commits into
Open
Pragadeesh122 wants to merge 2 commits into
Pragadeesh122 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The branch ruleset requires 4 status checks to pass before merge:
But
test-apiandhelm-linthadif: needs.changes.outputs.X == 'true'conditions. When a PR didn't touch those paths, the jobs were skipped — and the ruleset treated "skipped" as not passing, blocking all merges even when CI was green.Fix
Remove the
ifconditions fromtest-apiandhelm-lintso they always run (similar tobuild, which already runs unconditionally). Thechangesjob still exists for informational purposes, but the downstream jobs are no longer gated on it.This unblocks:
.github/workflows/files