Skip to content

Update deprecated badges#5480

Merged
andyleejordan merged 1 commit into
PowerShell:mainfrom
Craftlgend:main
May 15, 2026
Merged

Update deprecated badges#5480
andyleejordan merged 1 commit into
PowerShell:mainfrom
Craftlgend:main

Conversation

@Craftlgend
Copy link
Copy Markdown
Contributor

@Craftlgend Craftlgend commented Apr 27, 2026

PR Summary

Fixed Shields.io deprecated badges
Closes #5471

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@andyleejordan
Copy link
Copy Markdown
Member

Can you say who is behind vsmarketplacebadges.dev? A little wary of a supply chain attack with that.

@Craftlgend
Copy link
Copy Markdown
Contributor Author

Craftlgend commented May 6, 2026

@andyleejordan this seems to be the official github regarding the vsmarketplacebadges.dev site. It is the only site i could personally find that is still able to generate Marketplace badges, and i saw it used by different extensions already since the changes of Shields.io. I personally dont see an issue with the sinte since the links are specifically svg, but if you have a problem with that i will just completely remove the badges and the problem is fixed. We can of course go with BadGen as mentioned in the other PR, but i dont see a difference between the two and the reason that that Repo hasnt had any uptates is probably because there have not been any issues with the project

@andyleejordan andyleejordan changed the title Deprcated Shields badges Update deprecated "shields" badges May 15, 2026
Copy link
Copy Markdown
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had Claude do some digging and was able to confirm that this is an explicitly approved source per https://github.com/microsoft/vscode-docs/blob/main/api/references/extension-manifest.md#approved-badges

Thanks for the fix!

@andyleejordan andyleejordan changed the title Update deprecated "shields" badges Update deprecated badges May 15, 2026
@andyleejordan andyleejordan merged commit 09bba76 into PowerShell:main May 15, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shields.io Visual Studio Marketplace Badges deprecated

2 participants