Repository navigation
Tighten DSC resource detection in AvoidAlias - #2280
Merged
Christoph Bergmeister (bergmeister) merged 2 commits intoOct 28, 2026
Merged
Christoph Bergmeister (bergmeister) merged 2 commits into
Christoph Bergmeister (bergmeister) merged 2 commits into
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Tighten DSC resource detection in AvoidAlias
Oct 28, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the AvoidAlias DSC resource-detection changes.
No open issues 🎉
What changed in this PR
This PR tightens DSC resource detection in the AvoidAlias rule so executable commands retain diagnostics while resource declarations remain excluded.
Changes:
- Require a configuration ancestor and a standalone command pipeline before recognizing resource declarations.
- Treat assignment and parenthesized-expression contexts as boundaries, and validate following-line resource bodies against their headers.
- Add regression coverage for assignments, scriptblocks, expressions, following-line property blocks, and pipelines.
| File | Description |
|---|---|
| Tests/Rules/AvoidUsingAlias.tests.ps1 | Adds regression tests ensuring executable commands retain alias and implicit-command diagnostics. |
| Rules/AvoidAlias.cs | Restricts DSC resource detection and validates following-line body associations. |
Review effort: Balanced
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2281
October 28, 2026 15:16
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 28, 2026 15:16
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 28, 2026 15:16
Christoph Bergmeister (bergmeister)
merged commit Oct 28, 2026
ee28f10
into
copilot/fix-auto-correct-aliases
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-review-comments
branch
October 28, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSC resource detection could suppress diagnostics for executable commands and scan sibling statements for ordinary commands. It also misclassified assignments, scriptblock expressions, and pipeline elements as resource declarations.
The resource declaration remains ignored; the executable commands retain their
Get-Verbdiagnostics.