Repository navigation
Preserve relative indentation in commented-out code - #2257
Merged
Christoph Bergmeister (bergmeister) merged 2 commits intoOct 27, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow guard addresses the reported defect with focused regression coverage; tests were not executed during review.
No open issues 🎉
What changed in this PR
This PR fixes a comment-run boundary case in PSUseConsistentIndentation, supporting #2231’s preservation of relative indentation in commented-out code.
Changes:
- Exclude comments with preceding code on the same line from comment-run offset calculation.
- Add a regression test for trailing comments after line-leading pipes, checking expected formatting and idempotence.
| File | Description |
|---|---|
| Tests/Rules/UseConsistentIndentation.tests.ps1 | Tests the reported pipeline case with NoIndentation and repeat formatting. |
| Rules/UseConsistentIndentation.cs | Adds an early return for comments preceded by code on the same line. |
Review effort: Balanced
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2258
October 27, 2026 18:15
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 27, 2026 18:15
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 27, 2026 18:15
Christoph Bergmeister (bergmeister)
merged commit Oct 27, 2026
3f33813
into
copilot/fix-psuseconsistentindentation-issue
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/preserve-relative-indentation-comments
branch
October 27, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on #2231. I've created this new PR, which merges into #2231, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.
Original PR: #2231
Triggering comment (#2231 (comment)):