[Feature] Add Node-side HTTP/HTTPS proxy support with auto-detect and manual override - #624
Draft
Power-Maverick with Copilot wants to merge 4 commits into
Draft
[Feature] Add Node-side HTTP/HTTPS proxy support with auto-detect and manual override#624Power-Maverick with Copilot wants to merge 4 commits into
Power-Maverick with Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] Add HTTP/HTTPS proxy support for PPTB desktop app
[Feature] Add Node-side HTTP/HTTPS proxy support with auto-detect and manual override
Aug 8, 2026
Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>
Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>
Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds first-class proxy support for Node-side networking paths (Supabase, Azure Blob downloads, npm/pnpm installs) with system auto-detection, manual override, NO_PROXY handling, custom CA bundle support, and proxy auth challenge flow. BrowserView networking remains unchanged.
Type of change
Changes
Proxy core (
src/main/managers/proxyManager.ts)manual→auto(ElectronresolveProxy) →none.tls.rootCertificates.HTTP_PROXY,HTTPS_PROXY,NO_PROXY) before networked managers initialize.app.on("login", ...), prompting only on actual 407-style challenges and storing credentials through existing secure encryption patterns (no plaintext persistence).Settings model + persistence
mode: "auto" | "manual" | "none"manualProxyUrl?: stringnoProxyList?: string[]caBundlePath?: stringSettingsManagerfollowing existing settings conventions.Settings UI (
src/renderer/modules/settingsManagement.ts)Network call-site wiring
Docs
docs/PROXY_TESTING.mdwith local validation recipes for:Example (resolved proxy application):
Architecture checklist
Packages (
types&validation)packages/If you did change a package:
@pptb/types(types): type definitions updated and version bumped inpackages/types/package.json@pptb/validate(validation): validation rules updated and version bumped inpackages/validation/package.jsonCode quality
pnpm run typecheckpasses with 0 errors (warnings are acceptable)pnpm run lintpasses with 0 errors (warnings are acceptable)pnpm run buildcompletes successfullyTesting
pnpm run test:unitpasses (for changes tosrc/main/,src/common/, orsrc/renderer/utilities)pnpm run test:e2epasses (for UI / navigation / end-to-end flows)pnpm run dev)Scenario tested:
Proxy mode switching (auto/manual/none), manual proxy routing validation, custom CA bundle path handling, auth challenge prompt flow, and NO_PROXY bypass behavior.
Screenshots / recordings
UI update in Settings: new Network / Proxy section with mode selector, manual URL, NO_PROXY, CA bundle picker, and Test Connection status.
Breaking changes
Reviewer notes