feat(orchestrator): fail the run properly on a missing skill variant - #909
Merged
gewenyu99 merged 3 commits intoJul 15, 2026
Conversation
Replaces the dev/CI-only throw with an unconditional wizardAbort — same behavior on every build (no tree-shake gate to maintain): the user gets the error outro pointing at wizard@posthog.com, the WizardError context carries the misses, and the per-miss log + analytics capture stay. Generated-By: PostHog Code Task-Id: fafc230d-6f14-4e4d-9462-0e7f18a1eec1
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
The abort outro now links the agent-skills repo (github.com/PostHog/skills) and the manual install docs alongside the wizard@posthog.com contact. Generated-By: PostHog Code Task-Id: fafc230d-6f14-4e4d-9462-0e7f18a1eec1
Skills download points at context-mill releases (where skills actually publish), and the manual-setup link uses the framework's own docsUrl from FRAMEWORK_REGISTRY, falling back to the generic docs when detection found no framework. Generated-By: PostHog Code Task-Id: fafc230d-6f14-4e4d-9462-0e7f18a1eec1
gewenyu99
marked this pull request as ready for review
July 15, 2026 18:38
gewenyu99
merged commit Jul 15, 2026
970b0c9
into
experiment/orchestrator-pi-runtask
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses @sarahxsanders's review comment on #853 (#853 (comment)): the preflight previously crashed in dev/CI builds only and silently degraded in production. One behavior everywhere is easier to maintain, so this replaces the tree-shaken throw with an unconditional
wizardAbort:WizardErrorcontext carries every missingtype/skillpair and the framework, captured to analytics viacaptureException.orchestrator skill variant missingcapture (on the wizard-switchboard dashboard) are unchanged.IS_PRODUCTION_BUILDgate and its tree-shake reasoning are gone.Same
wizardAbort({message, error: WizardError})pattern asabortOnInstallFailureuses for linear-flow skill-install failures.Testing
pnpm build+ orchestrator/loader suites green (171 tests), full suite + lint green on the pre-cherry-pick branch.Created with PostHog Code