fix(analytics): keep idle socket errors non-fatal - #1199
Closed
jaredrainsha wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hey, appreciate the fix here. I have a different fix in #1203 I will keep an eye on this and bump packages that depend on undici. I really don't wanna add a catch at the root level for an exception that should have never made it outside the MCP package we use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
posthog-nodeexception autocapture receives Node HTTP/2'sInformationalError: socket idle timeout, it treats the uncaught event as fatal because the wizard has no process-level exception listener. The SDK then flushes and exits the interactive wizard mid-run.Closes #1198.
Changes
Test plan
posthog-nodeprobe stayed alive for the exact idle timeout and exited 1 for a generic errorLLM context
Implemented and verified with OpenAI Codex assistance. The root cause was confirmed against the installed
posthog-node5.45.2 exception-autocapture behavior, and the final diff was constrained to the wizard process boundary and its tests.