fix(wizard-ci): make snapshot runs render colour and report real failures - #3749
Draft
gewenyu99 wants to merge 1 commit into
Draft
fix(wizard-ci): make snapshot runs render colour and report real failures#3749gewenyu99 wants to merge 1 commit into
gewenyu99 wants to merge 1 commit into
Conversation
…ures Generated-By: PostHog Desktop Task-Id: 937a0411-9322-45ee-b214-0fb713a58bb4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four fixes to the snapshot harness, all found while running
wizard-ciagainst the wizard 2.71.0 RC.snapshots.tsHTML-escaped the raw.ansframes into a<pre>, so every rendered PNG showed literal escape codes instead of the terminal — it now parses the SGR grammarrowToAnsiemits.snapshots-review.tscast away thecommitAndCreatePRresult and never checkedsuccess, so a commit that never landed printed✓ review PR: (created)and exited 0; checking it is what surfaced the third bug,createSignedCommitcreating the branch ref before the commit and dying onReference already existsfor every retry. Finallye2e.tsasserted non-integration programs end on a screen literally namedoutro, scoring a fully successfulupload-source-mapsrun as a failure because its outro issource-maps-outro.--render-onlyre-renders from frames already on disk, so a renderer change no longer costs a 20-minute agent run.Created with PostHog Desktop