Skip to content

fix(wizard-ci): make snapshot runs render colour and report real failures - #3749

Draft
gewenyu99 wants to merge 1 commit into
mainfrom
posthog/wizard-ci-snapshot-harness-fixes
Draft

fix(wizard-ci): make snapshot runs render colour and report real failures#3749
gewenyu99 wants to merge 1 commit into
mainfrom
posthog/wizard-ci-snapshot-harness-fixes

Conversation

@gewenyu99

Copy link
Copy Markdown
Contributor

Four fixes to the snapshot harness, all found while running wizard-ci against the wizard 2.71.0 RC.

snapshots.ts HTML-escaped the raw .ans frames into a <pre>, so every rendered PNG showed literal escape codes instead of the terminal — it now parses the SGR grammar rowToAnsi emits. snapshots-review.ts cast away the commitAndCreatePR result and never checked success, so a commit that never landed printed ✓ review PR: (created) and exited 0; checking it is what surfaced the third bug, createSignedCommit creating the branch ref before the commit and dying on Reference already exists for every retry. Finally e2e.ts asserted non-integration programs end on a screen literally named outro, scoring a fully successful upload-source-maps run as a failure because its outro is source-maps-outro. --render-only re-renders from frames already on disk, so a renderer change no longer costs a 20-minute agent run.


Created with PostHog Desktop

…ures

Generated-By: PostHog Desktop
Task-Id: 937a0411-9322-45ee-b214-0fb713a58bb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant