feat: add google-adk node-weather ai-observability fixture - #3711
Open
marco-g-pm wants to merge 2 commits into
Open
feat: add google-adk node-weather ai-observability fixture#3711marco-g-pm wants to merge 2 commits into
marco-g-pm wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Same demo values as the sibling ai-observability fixtures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The wizard has no fixture to prove the Google ADK path. PostHog/posthog-js#4687 adds
PostHogADKPlugin, and noai-observabilityapp exercises an ADKRunnerplugin.for PostHog/posthog-js#4687
Changes
apps/ai-observability/google-adk/node-weather: the same two-turnget_weatherround trip as the other weather apps, on@google/adk, so a diff against any of them isolates the framework.PostHogADKPluginin theRunner'splugins, identity inherited from ADK's ownuserIdandsessionId, two traces in one session, flush before exit.$ai_spanis not graded as a failure.Testing
FunctionTool,Runner,runAsync,createSession) and the working example in feat(ai): add Google ADK (@google/adk) observability adapter posthog-js#4687.tsc --noEmitagainst installed deps, becauseregistry.npmjs.orgis unreachable behind this sandbox's TLS interception.wizard-ci --app ai-observability/google-adk/node-weather, which needs thegoogle-adkvariant from feat: add google-adk variant to ai-observability skill context-mill#375.🤖 Agent context
Written by Claude Code from PostHog/posthog-js#4687, mirroring #3675 (the Go fixture rollout). Skills invoked: writing-pr-descriptions, writing-user-facing-copy, writing-code-comments.