fix(replay): re-adopt stylesheets when a shadow host is removed and re-added - #4731
Open
fasyy612 wants to merge 1 commit into
Open
fix(replay): re-adopt stylesheets when a shadow host is removed and re-added#4731fasyy612 wants to merge 1 commit into
fasyy612 wants to merge 1 commit into
Conversation
fasyy612
requested review from
TueHaulund,
arnohillen and
ksvat
and removed request for
a team
September 1, 2026 19:20
Contributor
|
Contributor
Replay incident risk checkThis diff touches code involved in past incidents. This is a heads-up, not a verdict: read the matched sections of INCIDENTS.md and answer their review questions before merging. For a judgment on whether this diff has the same failure mode, run the |
Contributor
Contributor
|
Size Change: +5.06 kB (+0.02%) Total Size: 20.8 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Components styled via
shadowRoot.adoptedStyleSheetslose all styling mid-replay when an SPA navigation detaches and reattaches them. Reported by a customer whose header renders unstyled ("mobile mode") from the navigation onward while the live page looks correct.On the live page the browser preserves a moved element's shadow root and adopted sheets, so the recorder (which already tracks that shadow root) correctly emits no new
AdoptedStyleSheetevent. The replayer however rebuilds the re-added host with a fresh, empty shadow root.Changes
The replayer keeps a
lastAdoptedStyleIdsmap (latest adopted styleIds per host id) and re-adopts when it attaches a shadow root for a known host: immediately during live playback, or via the existing pending-adoptions flush during fast-forward. The map is cleared wherever the style mirror resets (full snapshot rebuild, playback from baseline, destroy), so stale ids never cross a document swap.Replay-side only, so playback of existing recordings is fixed retroactively.
Verification:
replayer,adopted-stylesheet-rejected, andfast-forwardsuites: 70/70 pass.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset fileIf releasing new changes
🤖 Agent context
Autonomy: Human-driven (agent-assisted) — or — Fully autonomous